New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spectests): fix timeout and run in CI #456

Merged

0xfourzerofour merged 1 commit into main from josh/docker-spec-test

Oct 9, 2023

Collaborator

0xfourzerofour commented Oct 5, 2023 •

edited

Loading

Closes #147

Proposed Changes

Add spec tests to CI and fix timeout issues due to race condition
Update debug_sendBundleNow so that we wait for the pool to be updated to the same transaction block before returning

codecov bot commented Oct 5, 2023 •

edited

Loading

Codecov Report

Merging #456 (e404ebc) into main (f1c3f5d) will decrease coverage by 0.09%.
The diff coverage is 2.27%.

Files	Coverage Δ
crates/builder/src/server/mod.rs	`0.00% <ø> (ø)`
crates/builder/src/task.rs	`0.00% <ø> (ø)`
crates/builder/src/transaction_tracker.rs	`86.74% <100.00%> (ø)`
crates/builder/src/server/local.rs	`0.00% <0.00%> (ø)`
crates/builder/src/server/remote/client.rs	`0.00% <0.00%> (ø)`
crates/builder/src/server/remote/server.rs	`0.00% <0.00%> (ø)`
crates/pool/src/server/mod.rs	`33.33% <0.00%> (-66.67%)`	⬇️
crates/rpc/src/debug.rs	`0.00% <0.00%> (ø)`
crates/builder/src/bundle_sender.rs	`0.00% <0.00%> (ø)`

Flag	Coverage Δ
unit-tests	`52.20% <2.27%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
rundler binary	`0.00% <ø> (ø)`
builder	`45.04% <4.34%> (-0.03%)`	⬇️
dev	`0.00% <ø> (ø)`
pool	`59.54% <0.00%> (-0.10%)`	⬇️
provider	`1.33% <ø> (ø)`
rpc	`18.26% <0.00%> (-0.25%)`	⬇️
sim	`82.61% <ø> (ø)`
tasks	`∅ <ø> (∅)`
types	`93.56% <ø> (ø)`
utils	`7.20% <ø> (ø)`

0xfourzerofour marked this pull request as ready for review

October 6, 2023 13:53

0xfourzerofour requested review from dancoombs, dphilipson and alex-miao as code owners

October 6, 2023 13:53

dancoombs reviewed

View reviewed changes

.github/workflows/compliance.yaml Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/rpc/src/debug.rs Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/builder/src/transaction_tracker.rs Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved

dancoombs reviewed

View reviewed changes

crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved

0xfourzerofour force-pushed the josh/docker-spec-test branch from 0dfb7a5 to efdbad3 Compare

October 6, 2023 19:41

dancoombs reviewed

View reviewed changes

crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved

dancoombs approved these changes

View reviewed changes


          chore(spectests): fix timeout issues and add to CI

a8f629c

0xfourzerofour force-pushed the josh/docker-spec-test branch from e404ebc to a8f629c Compare

October 9, 2023 18:45

0xfourzerofour merged commit 440c096 into main

6 checks passed

0xfourzerofour deleted the josh/docker-spec-test branch

October 9, 2023 18:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet